I disagree, crafting weapon mods would not work.
Basic mods, ok. Advanced mods? Not only would it not be realistic, at least how I understand it, but it would also be an inferior alternative to having to find or shop for them which is much harder but also a lot more rewarding and cool.